-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code.cmd #209315
Update code.cmd #209315
Conversation
Fixed the issue where the cmd window remains when executing the code command under cmd to open vscode. The issue : microsoft#70139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "START /B" to start a new process in the background to start vscode. The empty string is to fix the problem of the pop-up window prompting to select the js interpreter in the windows system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It work in windows10
@DonJayamanne May I have the Honor to contribute for the vscode?Please. |
@longtsing The issue has been closed, please create a new issue so we know what you are trying to address. |
the new issue is these: |
@DonJayamanne hello? |
@longtsing I would suggest you first wait for the issue to get triaged by @roblourens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我试了一下,windows10上确定能用,不过 /b 参数加不加都一样
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,不过加 /B 参数是为了保持兼容性,windows 10下可能加不加都一样,但是其他的版本的 windows 加个 /b 应该好一些。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就等给 issue 分类,然后合并提交了。
See #66750 |
Fixed the issue where the cmd window remains when executing the code command under cmd to open vscode.
The issue :
#210876
#70139
The reason for the bug is that when cmd opens vscode in the foreground, it will get stuck in the event loop of electron.
So the cmd window can only exit automatically after vscode exits.
The solution is to open a new process and open vsocode in the background.